-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-73695] BUG: Dashboard shows white space on certain width space >900px #9667
Conversation
Signed-off-by: Thorsten Scherler <[email protected]>
@janfaracik @timja There is a different approach to solve the underlying problem which would mean to change |
Tried it and works fine 👍 One for the future but would be good to have the table be properly responsive in the future, shuffling/showing/hiding elements as necessary to fit the screen. |
Signed-off-by: Thorsten Scherler <[email protected]>
@janfaracik yeah I agree, but in the end I did not wanted to start this since I am not sure about the extensibility of the columns and whether or not we want to combine the media query with using |
Definitely - will definitely be a big job. I'm conducting some research on that topic now actually - https://forms.gle/51uqa5yyPvknDETb9 - if you'd be free for filling it in :) Should take a couple minutes at most. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
@Artmorse @janfaracik @scherler I suspect this change to have introduced a small regression, as there seems to be a "useless" horizontal scrollbar in the overviews: This may have gone unnoticed as the scrollbar disapears when the list / table loses focus. |
Problem:
After with the pr:
See JENKINS-73695.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@janfaracik @timja @basil
Before the changes are marked as
ready-for-merge
:Maintainer checklist